Feature/jrpc log limit #2572
Merged
Feature/jrpc log limit #2572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Psykepro
approved these changes
Oct 4, 2023
ARR552
reviewed
Oct 4, 2023
ARR552
approved these changes
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2502.
What does this PR do?
Add limits when creating new filters or getting logs from state.
New configurations were created to allow the limits to be defined by the node, but not configuration changes are required if the default values are enough for your use case.
MaxLogsCountis a configuration to set the maximum number of logs that can be returnedin a single call to the state, if zero it means no limit
MaxLogsBlockRangeis a configuration to set the max range for block number when querying TXslogs in a single call to the state, if zero it means no limit
Default Values:
Reviewers
@ToniRamirezM
@Psykepro